search

OpenCCG / openccg

OpenCCG library for parsing and realization with CCG
http://openccg.sourceforge.net/
Other
205 stars 45 forks source link

Migrate to Maven #27

Closed zaibacu closed 5 years ago

zaibacu commented 5 years ago

mvn package will now:

Old ant build.xml is still there, because there are parts like site and documentation which are not yet covered by maven

mwhite14850 commented 5 years ago

Hi Šarūnas Navickas

Thanks for this suggestion! This appears to be related to what Adam Leskis has been working on with making a Docker image for the build:

https://github.com/OpenCCG/openccg/issues/23

It would be helpful if you and Adam (also Dave Howcroft?) could comment on whether it would make sense to incorporate both of these suggestions or just one or the other, and if both, whether there are any conflicts to resolve or synergies to pursue.

Mike

lpmi-13 commented 5 years ago

The migration to use maven is sensible in any case, and the docker build branch could easily be rebased to incorporate this after its merged in.

zaibacu commented 5 years ago

Yes, I think these two are independant. If anything, this should make Docker image creation easier since maven is quite easy to setup and dependencies are downloaded instead of copied manually

dmhowcroft commented 5 years ago

My initial impression is that this build process simplifies the work that @lpmi-13 did to create the Docker image, so I also agree it would make sense to incorporate this PR before doing that one.

mwhite14850 commented 5 years ago

Ok, thanks all, went ahead with the merge!

lpmi-13 commented 5 years ago

just a note that we may also want to update the installation documentation to incorporate the new maven process.

mwhite14850 commented 5 years ago

It would be great if someone who is familiar with maven could add this!

On Thu, Jul 18, 2019 at 12:12 PM Adam Leskis notifications@github.com wrote:

just a note that we may also want to update the installation documentation to incorporate the new maven process.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/OpenCCG/openccg/pull/27?email_source=notifications&email_token=AA6G7TNRTXVFKVNJPGHLIUDQACJAJA5CNFSM4ICJQPOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2I72UI#issuecomment-512884049, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6G7TP6XKVLDA6J5YIUDZTQACJAJANCNFSM4ICJQPOA .