search

OpenCDSS / cdss-app-statecu-fortran-test

Automated tests for StateCU software.
0 stars 0 forks source link

ym2015B dataset does not create BD1 output file #5

Closed smalers closed 2 years ago

smalers commented 3 years ago

I have been doing comparisons of different datasets using the testing framework. Now I am going through all the datasets and documenting what I find. The ym2015 scenario has minor differences between 13.10 and 14.0.0 versions. However, the 14 version does not output the BD1 file for ym2015B scenario so I can't compare that scenario using time series. The ccu files are different, with the ym2015B file having isuply=0. The code has some conditions for when the BD1 file is opened but I don't have time to figure that out. I tried setting to isuply=1 to see if that would generate a BD1 file but then I get the following:

image

My questions are:

  1. Is the latest code supposed to NOT create the BD1 file?
  2. Can the ym2015B dataset be run in a way to generate BD1 so that automated tests can compare the time series in the binary files?
  3. Is this going to be an issue with every dataset?

This also points out that there is a need to do automated tests for different configuration variables, but I am focusing on running the published datasets.

I'm going to continue running all the datasets and see how it goes with the different scenarios.

smalers commented 2 years ago

I updated the code with fix to mainxc.for and updated the version to 14.0.1. I reran the dataset tests that previously had missing BD1 files and the differences are small. I updated the the test results. I will put out a release with this fix. I'm closing this issue.