OpenCDSS / cdss-app-statecu-fortran

Colorado's Decision Support Systems (CDSS) StateCU consumptive use model code, documentation, tests
GNU General Public License v3.0
1 stars 1 forks source link

Water budget progress messages are not sequential #28

Closed smalers closed 3 years ago

smalers commented 3 years ago

StateCU 14.0.0 has output similar to the following. Why is the output not sequential?

 Preparing Water Budget:
   processed through structure #          25
   processed through structure #          75
   processed through structure #         100
   processed through structure #         125
   processed through structure #         150
   processed through structure #         175
   processed through structure #         200
   processed through structure #         225
   processed through structure #         250
   processed through structure #         300
   processed through structure #         325
   processed through structure #         350
   processed through structure #          50
   processed through structure #         275
   processed through structure #         375
smalers commented 3 years ago

Erin Wilson responded:


Steve –

The first time the water budget is processed, it goes through every structure and writes out two separate temporary *.dwb files – one with structures that have complete data and, therefore, complete water budgets, and one with structures that have missing data. The second time through, it only processes and fills structures with missing data, so depending on “where” the missing data is, it might indicate a different structure number for each 25th print out. The last time through, it combines the complete and “filled” data back into the original order. I’ve never noticed this before, but am not surprised that it could happen. I have discontinued writing out the intermediate step to avoid confusion – it is also no longer necessary because the executable is so much faster now.


Erin's code is attached with names changed to .txt:

wsupsum.for.txt gcommon.inc.txt

smalers commented 3 years ago

I have already made changes to the code to change the copyright and a couple of file unit numbers so will manually merge the changes related to the messages. Below are my merge comments.

The output is now:

 Preparing Water Budget
 Writing water budget output:
   processed through structure #          25
   processed through structure #          50
   processed through structure #          75
   processed through structure #         100
   processed through structure #         125
   processed through structure #         150
   processed through structure #         175
   processed through structure #         200
   processed through structure #         225
   processed through structure #         250
   processed through structure #         275
   processed through structure #         300
   processed through structure #         325
   processed through structure #         350
   processed through structure #         375
   finished
 Writing consumptive use summary

I'm closing this issue.