cm2015 dataset opr file has broken rule 46

[smalers]

The cm2015_StateMod dataset has a broken opr file. This is a known issue and fix was provided by WWG but need to update the official dataset when there is time. Otherwise, need to manually edit the file to fix so that automated tests can run. I'm assigning to Brian.

The error is:

  Oprinp; Problem with Operating right type = 46 ID = 39005630.03
          Expect the destination to be Multiple in
          order to allow 1 to 10 destinations to be
          specified.
          Recommend you revise the operating rule file.

The operating rule in cm2015H.opr is:

39005630.03 Split Silt Plan                          37503.15067      0.       1 563PL             43 3900563PL          1 NA                 0      46 NA           Diversion           0       2       0    9999 AcctSplit to Multiple Owners
                                                                                 3505PL            57

The fix is the following, made to cm2015H.opr and cm2015B.opr:

39005630.03 Split Silt Plan                          37503.15067      0.       1 Multiple           1 3900563PL          1 NA                 0      46 NA           Diversion           0       2       0    9999 AcctSplit to Multiple Owners
                                                                                 563PL             43
                                                                                 3505PL            57

[macphersonbr]

I see that statemod-17.0.2-gfortran-win-64bit.exe does result in this error. However when I make the fix I am getting an abort from cm2015B.rsp in June 1910 with the message:

Stopped in Carrpl

Interestingly cm2015H.rsp runs all the way through with the fix. I will reach out to Steve and Kara to get an .opr file in case I made an error with the fix.

[macphersonbr]

I also notice that with StateMod_Model_15.exe with the changes in the .opr files result in the error:

Oprfind;  Problem Reading Operating Rule ID = 39005630.03 
            The Structure type specified for a source, destination
            reuse plan, etc. is =         Plan with ID = Multiple    
            But this ID cannot be found in the         Plan file  (*.pln)
            Recommend you confirm it is the appropriate structure type.
            Remember enter NA if none are required.
            Number of entries read from the file =    10

so I am not sure if the change is backward compatible.

[smalers]

This is also an issue for the NP2018_StateMod_modified dataset. The operating rule that has an issue is:

  Oprinp; Problem with Operating right type = 46 ID = 614_PLN.02
          Expect the destination to be Multiple in
          order to allow 1 to 10 destinations to be
          specified.
          Recommend you revise the operating rule file.

The original rule in the NP2018H file is:

614_PLN.02  Split_Eureka_Full_Plan_60_40             13765.00002      0.       1 614_60PLN         60 614_PLN            1 NA                 0      46 NA           Diversion           0       2       0    9999 AcctSplit to Multiple Owners
                                                                                 614_40PLN         40

I changed to the following based on the comment above the rule. Also the original rule was using tabs in the file on the second line, which I converted to spaces.h

614_PLN.02  Split_Eureka_Full_Plan_60_40             13765.00002      0.       1 Multiple           1 614_PLN            1 NA                 0      46 NA           Diversion           0       2       0    9999 AcctSplit to Multiple Owners
                                                                                 614_60PLN         60
                                                                                 614_40PLN         40

[Rayrbennett]

The ability to specify multiple is not backward compatible.
It is a relatively recent enhancement to provide relatively new capability for several operating rights.
Ray Sent from my iPhone

On Sep 10, 2021, at 8:48 PM, macphersonbr @.***> wrote:

 I also notice that with StateMod_Model_15.exe with the changes in the .opr files result in the error:

Oprfind; Problem Reading Operating Rule ID = 39005630.03 The Structure type specified for a source, destination reuse plan, etc. is = Plan with ID = Multiple
But this ID cannot be found in the Plan file (*.pln) Recommend you confirm it is the appropriate structure type. Remember enter NA if none are required. Number of entries read from the file = 10 so I am not sure if the change is backward compatible.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[Rayrbennett]

The best way to interpret this message is the user is trying to perform an operation that was not operational in earlier executables.

Sent from my iPhone

On Sep 11, 2021, at 10:18 AM, Steve Malers @.***> wrote:

 This is also an issue for the NP2018_StateMod_modified dataset. The operating rule that has an issue is:

Oprinp; Problem with Operating right type = 46 ID = 614_PLN.02 Expect the destination to be Multiple in order to allow 1 to 10 destinations to be specified. Recommend you revise the operating rule file. The original rule in the NP2018H file is:

614_PLN.02 Split_Eureka_Full_Plan_60_40 13765.00002 0. 1 614_60PLN 60 614_PLN 1 NA 0 46 NA Diversion 0 2 0 9999 AcctSplit to Multiple Owners 614_40PLN 40 I changed to the following based on the comment above the rule. Also the original rule was using tabs in the file on the second line, which I converted to spaces.h

614_PLN.02 Split_Eureka_Full_Plan_60_40 13765.00002 0. 1 Multiple 1 614_PLN 1 NA 0 46 NA Diversion 0 2 0 9999 AcctSplit to Multiple Owners 614_60PLN 60 614_40PLN 40 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[smalers]

To respond to Brian's question about cm2015B not running, I added a new issue to the StateMod code repository. I don't know if it is a data or code issue.

Issue 74