Open smalers opened 3 years ago
Here is my feedback based on discussions with Josh and the pull request.
RunProgram
- can copy and paste code for this. This involves setting up a tabbed pane and then adding parameters to each pane.MailProgram
as a choice with possible values JavaAPI
, Sendmail
, WindowsMail
.
JavaAPI
since built in.SMTPServer
: Such as Google SMTP server address.SMTPAccount
or SMTPLogin
. If this is needed for the other email programs then maybe add a separate tab "SMTP".SMTPPassword
. I need to see Markdown documentation ASAP explaining this..mailpass
file, the documentation needs to be very clear that it is plain text and relies on the user's account being known only to the user. If Linux, the software can check for file mode 600 but I can add that later when I test on Linux. I suggest defaulting the file to a more standard Windows user folder such as under %APPDATA%\tstool\.smtp.cfg
to take advantage of the security of that folder. On Linux, maybe use $HOME/.tstool/NN/system/.smtp.cfg
.RunR
command for how to run a program. This can get complicated so take a cut and I can review.sendmail
program will be called with command line necessary to send the email. Is any software setup needed? It is OK to say that it is not yet implemented.RunR
command for how to run a program. Take a cut and I can review.checkParameters
method:
Message
or MessageFile
, not both.
The
SendEmailMessage
command has been started and needs to be finished to satisfy a project to monitor SNODAS website data. In that system, a system process is going to be run to check that the software is properly creating output. A check-in email will be sent on some frequency by running the check as a cron process. The command uses a Java API so hopefully there are no issues with that. In addition to implementing typical email handling capability, the main issue is how to avoid using public credentials in command files. We at least need to evaluate how to do some basic authentication to support interactive and automated use. Some thoughts are:sendmail
,mail
or other program so that email authentication is handle by operating systemRunProgram
,RunR
, and other commands. The TSTool command would need to take input from the command and put together the proper system call..pgpass
configuration file. It has mode600
on Linux meaning that only the owner can see. Then the software needs to be told to use. On Windows, the file would be saved in the user's data so would only be cracked if someone broke into their account.SystemLogin
andSystemPassword
property descriptions. Using a prompt may be OK if the task is actually run interactively (DO NOT LOG THE PASSWORD in log messages or other output).We just need to get this working at some functional level. All examples should be documented in Markdown so they can be folded into the TSTool command documentation.