search

OpenCHAMI / bss

MIT License
1 stars 2 forks source link

Ignore case of MAC addresses and fix postgres log messages #1

Closed synackd closed 5 months ago

synackd commented 8 months ago

Summary and Scope

Ignore case when dealing with MAC addresses. This is done by storing MAC addresses in lower case and converting any MAC addresses in requests to lower case before comparison. It is not desirable to distinguish MAC addresses as different based on case; therefore, we ignore it.

Also, some log message reformatting is present in this PR. For instance, there was a postgres.Add prefix in the Delete() function. Further, periods at the ends of log messages are removed so that it looks better when concatenated with other errors.

Issues and Related PRs

Migrated from https://github.com/bikeshack/hms-bss/pull/7

Testing

Tested on:

Added integration tests that test addition/retrieval/deletion using MAC addresses of differing case.

Risks and Mitigations

More comprehensive integration tests should be implemented in the future.

synackd commented 7 months ago

Rebased onto new main with re-homing changes.