search

OpenCHAMI / deployment-recipes

Ochami deployment recipes
MIT License
8 stars 10 forks source link

Add ability to use custom cluster domain #47

Closed synackd closed 4 months ago

synackd commented 4 months ago

Currently, "openchami.cluster" is hard-coded as the cluster domain. It would be useful to be able to customize the domain for cases where DNS names use a custom domain. This PR adds the ability to customize the cluster domain by passing an extra (optional) argument to the generate-configs.sh script, e.g.:

./generate-configs foobar mydomain.tld

The second argument is optional, and not passing it will default the domain to "openchami.cluster". In the command above, the cluster base URL generated would be "foobar.mydomain.tld".

This PR also adds other improvements to the generate-configs.sh script like further checks and a more complete usage message.

synackd commented 4 months ago

Rebased to sign commits. Recloned the repo and didn't have signing configured.

synackd commented 4 months ago

Thanks!