This PR fixes a host of errors in the code that are highlighted by linters and static analysis.
As part of this PR, I updated chi to the most recent version and completed the removal of State Change Notifications, Redfish Events, and internal Discovery.
There are still a significant number of errors, particular in the test file smd-api_test.go. My editor still flags over 550 errors, primarily related to shortcuts in defining various structs for comparison as part of tests.
In addition, there are two unit tests that are still failing. At the moment, I'm not clear on what is being tested in either one. More importantly, I can't tell if the test is wrong or the behavior of the API is wrong. Either seems possible to me.
This PR fixes a host of errors in the code that are highlighted by linters and static analysis.
As part of this PR, I updated chi to the most recent version and completed the removal of State Change Notifications, Redfish Events, and internal Discovery.
There are still a significant number of errors, particular in the test file smd-api_test.go. My editor still flags over 550 errors, primarily related to shortcuts in defining various structs for comparison as part of tests.
In addition, there are two unit tests that are still failing. At the moment, I'm not clear on what is being tested in either one. More importantly, I can't tell if the test is wrong or the behavior of the API is wrong. Either seems possible to me.