search

OpenCLTBrigade / cmpd-holiday-gift

CMPD Explorers Christmas Project
MIT License
11 stars 24 forks source link

Registration & authentication #178

Closed chimon2000 closed 6 years ago

chimon2000 commented 6 years ago
AndrewNatoli commented 6 years ago

@chimon2000 Running locally I was able to get an auth token to register, and when I filled out the registration form I got:

{
  "error": {
    "code": 400,
    "message": "MISSING_EMAIL",
    "errors": [
      {
        "message": "MISSING_EMAIL",
        "domain": "global",
        "reason": "invalid"
      }
    ]
  }
}

when submitting the registration. Ever run into this?

chimon2000 commented 6 years ago

@AndrewNatoli is this error happening when you hit the auth app?

AndrewNatoli commented 6 years ago

@chimon2000 Yeah, it was when trying to submit the registration form in the auth app

AndrewNatoli commented 6 years ago

@chimon2000 - Auth app falls into an infinite redirect loop when you run it using yarn start-client from the project root. If you run the app individually though it seems to work..

AndrewNatoli commented 6 years ago

We'll also need a custom email handler

https://firebase.google.com/docs/auth/custom-email-handler

"You can now sign in with your new account" unfortunately isn't something valid to show our users since they need to be approved. :(

chimon2000 commented 6 years ago

Good point, do we want to do that as part of this PR @AndrewNatoli ?

chimon2000 commented 6 years ago

A few things missing from this PR: