search

OpenCLTBrigade / codeforcharlotte.org

[OLD] We have deployed the laddr platform for our new CfC website.
5 stars 19 forks source link

Updated leadership page template #162

Closed AndrewNatoli closed 8 years ago

AndrewNatoli commented 8 years ago

Revised /templates/team/leadership.tpl

Photos now stay circular and scale for different window sizes.

RowdyChildren commented 8 years ago

I will take a look and push the change

RowdyChildren commented 8 years ago

@AndrewNatoli they seem a bit big when I change my chrome window size, is this expected

AndrewNatoli commented 8 years ago

@RowdyChildren What size are you changing to (Phone, Tablet, Desktop, Super high desktop resolution)?

On tablets they can be a little large as they fall under the left sidebar and the container takes up the full width. On mobile they collapse to one per row so a single image will take up the full width.

RowdyChildren commented 8 years ago

yes, I see what you mean. It looks pretty shitty when there is one small image per row. Change has been pushed.

On Fri, Dec 18, 2015 at 8:23 PM Andrew Natoli notifications@github.com wrote:

@RowdyChildren https://github.com/RowdyChildren What size are you changing to (Phone, Tablet, Desktop, Super high desktop resolution)?

On tablets they can be a little large as they fall under the left sidebar and the container takes up the full width. On mobile they collapse to one per row so a single image will take up the full width.

— Reply to this email directly or view it on GitHub https://github.com/CodeForCharlotte/codeforcharlotte.org/issues/162#issuecomment-165932207 .

RowdyChildren commented 8 years ago

Changed pushed and approved, change is now in production

AndrewNatoli commented 8 years ago

So... it's fine as-is then as it's one full-width image per row? Or should I look into getting two per row on mobile?

RowdyChildren commented 8 years ago

yeah, it is fine. There is one size in which the images are huge and super pixelly, but the likely hood of that exact really strange window size occurring is not high...so don't worry about it