1D Transient Navier Stokes Example

[ssafaei]

1D solver for steady and pulsatile flow in straight, compliant vessels. Extension to bifurcating vessels completed. Creating the geometry of femoral artery using VPH anatomical data completed.

[adamreeve]

Somehow you've removed David from the list of contributors in Navier_stokes_routines.f90 when merging, you might want to add him back and add yourself?

[adamreeve]

I just did a quick skim over out of interest, is Chris or someone else assigned to review this? I can review it if you'd like. It looks good so far.

[ssafaei]

Chris is not around for a few days, so no one is assigned yet. That would be great, I guess David wanted to review it as well since there were some conflicts between our codes.

[adamreeve]

Just a small issue in navier_stokes_routines.f90, you use field_label_set_and_lock, but it should probably just be field_label_set as there shouldn't be any reason to prevent users from chaning a field label.

[adamreeve]

I've finished going through this. After changing the DERIVATIVES(1) line back to DERIVATIVES(derivative) all the nightly tests do pass.

[ssafaei]

Thank you Adam, sorry, lots of bugs!! I fixed all of them, it should work properly now.

[dladd]

I've removed some of the unused variables from Navier_Stokes_equations_routines and made a pull request for Soroush's bifurcation branch here: https://github.com/Soroosh/cm/pull/1

[ssafaei]

All done, I also fixed some minor bugs in Navier_stokes and added some lines to solver_routines for that linking solver issue.

[ssafaei]

Just removed some unused subroutines in Navier_Stokes, NAVIER_STOKES_CONTROL_TIME_LOOP_PRE_LOOP NAVIER_STOKES_PRE_SOLVE_STORE_REFERENCE_DATA NAVIER_STOKES_PRE_SOLVE_STORE_PREVIOUS_DATA

[chrispbradley]

Closing as this has been superseded by another pull request