OpenCMISS / iron

Source code repository for OpenCMISS-Iron
9 stars 62 forks source link

Adding binding and library functions for setting Jacobian FD step size #161

Closed PrasadBabarendaGamage closed 6 years ago

PrasadBabarendaGamage commented 6 years ago

Addresses #159

Work in progress

chrispbradley commented 6 years ago

OK, looking at this again as part of the pull request I think the best way to resolve this is not have the Jacobian type and step size in the equations as this will apply to all Jacobians. I think the answer is to not set the jacobian and step size inside the equations create start/finish block. We don't even have any equations mappings let alone matrices until after equations create finish is called. We thus don't even know if we have any Jacobians then. The Equations_JacobianMatrixGet is used after equations create finish and so I think the Jacobian calcuation type and step size can be set then? i.e., after equations create finish?