OpenCMISS / iron

Source code repository for OpenCMISS-Iron
9 stars 62 forks source link

Data projection distance vector pointing opposite direction #19

Open jennyhelyanwe opened 8 years ago

jennyhelyanwe commented 8 years ago

When doing data projection evaluations (DataProjection_DataPointsProjectionEvaluate), the DataProjection_Newton<Elements/Faces/Lines>Evaluate subroutines are all currently evaluating distance vectors by doing:

DISTANCE_VECTOR(1:REGION_DIMENSIONS)=POINT_VALUES-INTERPOLATED_POINT%VALUES(:,NO_PART_DERIV)

This is wrong because it means that the distance vectors are pointing from the projected coordinates to the data point coordinates, which is opposite to how it should be. While this doesn't affect the value of the distance calculation, it is counter to the concept of projection and it affects any visualisations of the projection vectors if we choose to output them.

Changing the order of subtraction would correct the problem however we must be careful to check whether the change in sign of the distance vector is going to affect minimisation maths associated with the projection functions.