search

OpenCMISS / iron

Source code repository for OpenCMISS-Iron
9 stars 62 forks source link

V0.6.0 Commits Related to Reaction Diffusion #30

Closed vraj004 closed 6 years ago

vraj004 commented 8 years ago

The pull request has the following changes: (1) Ensure that the reaction diffusion problem type is included in the case statements for control loop post loop operations (2) Fix up of the filename pattern for the output files at each time step - removed a hard limit on the pattern. (3) A work around for the MPI_IN_PLACE openmpi bug that showed up on mac osx, openmpi 1.8.4

ghost commented 8 years ago

Admins: Please verify! Reply with

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist
vraj004 commented 8 years ago

“test this please" Vijay Rajagopal vijay.rajagopal@unimelb.edu.au

Senior Lecturer, Computational Cellular Mechanics Cell Structure and Mechanics Group http://www.cellularsmb.org/ Systems Biology Laboratory

Dept. of Mechanical Engineering University of Melbourne

On 10 Aug 2016, at 10:31 AM, OpenCMISS Robot, PhD notifications@github.com wrote:

Admins: Please verify! Reply with

"ok to test" to accept this pull request for testing "test this please" for a one time test run "add to whitelist" to add the author to the whitelist — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OpenCMISS/iron/pull/30#issuecomment-238904978, or mute the thread https://github.com/notifications/unsubscribe-auth/AA1-ZeMzjViAcByl1xOHj8uI_AfMUqqIks5qee7kgaJpZM4JhRZt.

chrispbradley commented 8 years ago

Hi @vraj004. Did you mean for this pull request to be against the v0.6.0 branch? I suspect that it is meant to be against devel? If so could you make another pull request against devel?

vraj004 commented 8 years ago

Hi @chrispbradley , I forked from opencmiss/iron and started changing the v0.6.0 in my fork. So I requested it to be merged with 0.6.0. I am not sure what these different versions are for. Is everyone supposed to use devel branch?

chrispbradley commented 8 years ago

Hi @vraj004. The vX.X.X branches are meant to the release versions (when we have a release!). The devel branch is the current branch that we are developing i.e., adding new features etc. etc. The idea is that when we are ready to do a release (and assume everything is working on the devel branch) a new version branch is created from the devel branch. Commits to a vX.X.X branch would be bug fixes for that release. As a developer you should probably be using the devel branch.

vraj004 commented 8 years ago

Just put in new pull request to devel branch.

chrispbradley commented 6 years ago

This pull request has now gone into develop so closing this pull request.