search

OpenCOMPES / sed

Single Event Data Frame Processor: Backend to handle photoelectron resolved datastreams
https://opencompes.github.io/sed/
MIT License
3 stars 1 forks source link

tof_binning as actual binning values #173

Closed steinnymir closed 2 months ago

steinnymir commented 11 months ago

Fromn a discussion in #169 we decided representing tof_binning as the explicit bin size is better than using the current exponent method. There should however be a note reporting the tof_binning value needs to be a power of 2.

current: tof[ns] = tof[steps] * tof_binwidth * 2**tof_binning Proposal: tof[ns] = tof[steps] * tof_binwidth * tof_binning

zain-sohail commented 11 months ago

Could you also put this in the documentation of binning (the binning.rst file) when a PR is created?

rettigl commented 11 months ago

Could you also put this in the documentation of binning (the binning.rst file) when a PR is created?

I would say it does not really belong there, at it is not related to the binning we do, but to the binning that was applied to the data by the detector readout. But it should go to the documentation, I agree. I will see where.

steinnymir commented 10 months ago

We will discuss details about this during the Beamtime, and figure out what the correct parameters for FLASH should be.

rettigl commented 2 months ago

Closed by PR #451