Closed zain-sohail closed 3 months ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Totals | |
---|---|
Change from base Build 9369127364: | 0.05% |
Covered Lines: | 6121 |
Relevant Lines: | 6671 |
Totals | |
---|---|
Change from base Build 9421216514: | 0.0% |
Covered Lines: | 6121 |
Relevant Lines: | 6671 |
Totals | |
---|---|
Change from base Build 9421216514: | 0.0% |
Covered Lines: | 6121 |
Relevant Lines: | 6671 |
As for the opencv question: This is a dependency via symmetrize. It was introduced here to limit the version because of a bug at some point: https://github.com/OpenCOMPES/sed/pull/111/commits/1f3b025ca47865f968eac000d4d8a83c89c0ff22 We can try removing it now again.
Totals | |
---|---|
Change from base Build 9421216514: | 0.0% |
Covered Lines: | 6121 |
Relevant Lines: | 6671 |
Totals | |
---|---|
Change from base Build 9421216514: | 0.0% |
Covered Lines: | 6121 |
Relevant Lines: | 6671 |
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Totals | |
---|---|
Change from base Build 9421216514: | 0.0% |
Covered Lines: | 6121 |
Relevant Lines: | 6671 |
I noticed that while some notebook dependencies were tagged optional, others weren't. And the pip users wouldn't be installing the optional ones without doing
pip install sed-processor[notebook]
So I have made all notebook dependencies optional. User can install with
pip install sed-processor[all]
orpip install sed-processor[notebook]
currently, since there are no other optional dependencies groups.This is reflected in the README now.