OpenCOMPES / sed

Single Event Data Frame Processor: Backend to handle photoelectron resolved datastreams
https://opencompes.github.io/sed/
MIT License
3 stars 2 forks source link

Optional dependencies #415

Closed zain-sohail closed 3 months ago

zain-sohail commented 3 months ago

I noticed that while some notebook dependencies were tagged optional, others weren't. And the pip users wouldn't be installing the optional ones without doing pip install sed-processor[notebook]

So I have made all notebook dependencies optional. User can install with pip install sed-processor[all] or pip install sed-processor[notebook] currently, since there are no other optional dependencies groups.

This is reflected in the README now.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9420343705

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 9369127364: 0.05%
Covered Lines: 6121
Relevant Lines: 6671

💛 - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9421738334

Details


Totals Coverage Status
Change from base Build 9421216514: 0.0%
Covered Lines: 6121
Relevant Lines: 6671

💛 - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9421737879

Details


Totals Coverage Status
Change from base Build 9421216514: 0.0%
Covered Lines: 6121
Relevant Lines: 6671

💛 - Coveralls
rettigl commented 3 months ago

As for the opencv question: This is a dependency via symmetrize. It was introduced here to limit the version because of a bug at some point: https://github.com/OpenCOMPES/sed/pull/111/commits/1f3b025ca47865f968eac000d4d8a83c89c0ff22 We can try removing it now again.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9431469140

Details


Totals Coverage Status
Change from base Build 9421216514: 0.0%
Covered Lines: 6121
Relevant Lines: 6671

💛 - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9496579533

Details


Totals Coverage Status
Change from base Build 9421216514: 0.0%
Covered Lines: 6121
Relevant Lines: 6671

💛 - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9496579760

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 9421216514: 0.0%
Covered Lines: 6121
Relevant Lines: 6671

💛 - Coveralls