Update dask version - Githubissues

OpenCOMPES / sed

Single Event Data Frame Processor: Backend to handle photoelectron resolved datastreams

https://opencompes.github.io/sed/

MIT License

3 stars 1 forks source link

Update dask version #448

Open rettigl opened 1 week ago

rettigl commented 1 week ago

The changes to the dfops in #411 allow to pass the tests with dask2024.6.2, however there are random failures during binning (see https://github.com/dask/dask/issues/11200). This requires further inspection.

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9651968197

Details

106 of 118 (89.83%) changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 91.908%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
sed/core/processor.py	7	9	77.78%
sed/loader/mpes/loader.py	70	80	87.5%
<!--	Total:	106	118	89.83%	-->

Totals
Change from base Build 9636700237:	0.05%
Covered Lines:	6463
Relevant Lines:	7032

💛 - Coveralls

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9652411782

Details

106 of 118 (89.83%) changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 91.911%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
sed/core/processor.py	7	9	77.78%
sed/loader/mpes/loader.py	70	80	87.5%
<!--	Total:	106	118	89.83%	-->

Totals
Change from base Build 9652390026:	0.09%
Covered Lines:	6465
Relevant Lines:	7034

💛 - Coveralls

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9652821299

Details

106 of 118 (89.83%) changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 91.868%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
sed/core/processor.py	7	9	77.78%
sed/loader/mpes/loader.py	70	80	87.5%
<!--	Total:	106	118	89.83%	-->

Totals
Change from base Build 9652390026:	0.05%
Covered Lines:	6462
Relevant Lines:	7034

💛 - Coveralls

zain-sohail commented 1 week ago

I saw some threads on xarray about ffill algorithms and maybe they help in not using map_overlap. Putting it here because it's related https://github.com/pydata/xarray/issues/6997 https://github.com/pydata/xarray/pull/6118

zain-sohail commented 5 days ago

Generally I find the error occuring in the current v1 branch as well

rettigl commented 5 days ago

It depends on the dask version, not our code. Did you check the dask version you were using?