coveralls
commented
4 months ago Pull Request Test Coverage Report for Build 10493563043
Details
- 68 of 71 (95.77%) changed or added relevant lines in 6 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.03%) to 92.722%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| sed/loader/flash/loader.py | 8 | 9 | 88.89% | ||
| tests/loader/flash/test_buffer_handler.py | 12 | 14 | 85.71% | ||
| <!-- | Total: | 68 | 71 | 95.77% | --> |
| Totals | |
|---|---|
| Change from base Build 10383509328: | 0.03% |
| Covered Lines: | 7122 |
| Relevant Lines: | 7681 |
I had heard this problem before that some files in a run can be invalid for different reasons. But basically some h5 datasets (channels) are not existing and then sed complaints. For example, run 100 would have files 1-10 with all correct channels but 11-13 not and afterwards correct. I encountered this issue with the invalid files containing no electron channels/ This PR just aims to remove such invalid files from being considered in the reading process. It could of course be argued that the other channels provide useful information but that leads to very complex handling of data, which would stil require most of these changes.
If necessary, I can provide the example h5 files that cause this issue but the test should make provide a small example.