Sxp fixes for new daq - Githubissues

OpenCOMPES / sed

Single Event Data Frame Processor: Backend to handle photoelectron resolved datastreams

https://opencompes.github.io/docs/sed/latest/

MIT License

3 stars 2 forks source link

Sxp fixes for new daq #510

Closed rettigl closed 2 weeks ago

rettigl commented 1 month ago

This PR brings in the changes to the sxp reader required for the new daq, while keeping compatibility to the old example tutorial.

It also adds the example dataset for sxp, and adds this to the documentation

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11783158442

Details

15 of 17 (88.24%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.006%) to 91.942%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
sed/loader/sxp/loader.py	15	17	88.24%
<!--	Total:	15	17	88.24%	-->

Totals
Change from base Build 11781677796:	-0.006%
Covered Lines:	6492
Relevant Lines:	7061

💛 - Coveralls

rettigl commented 2 weeks ago

Also side question, but have you attempted to use their xfel's own dataloader? Perhaps the data reduction can be done from that (if it works) and the further processing in SED, so we don't have to support updating the loader whenever there is a change.

This is something to look at after v1. For the last beam time, I have indeed used the parquet files directly, that are created using the SXP machinery.