OpenCS-ontology / OpenCS

Main OpenCS ontology repository
Creative Commons Attribution 4.0 International
5 stars 7 forks source link

Inaccurate tagged release commit message in tagged-release.yml #37

Closed Bartosz7 closed 8 months ago

Bartosz7 commented 8 months ago

The tagged-release workflow has changed recently, but it seems like the commit message is constant 'test' (is that intended?).

See: https://github.com/OpenCS-ontology/OpenCS/blob/e582f66314e20f2e0a750aceea24420d8ebe264d/.github/workflows/tagged-release.yml#L84

Suggestion: git commit -m "New tagged release: test" -> git commit -m "New tagged release: ${GITHUB_REF_NAME#v}"

Ostrzyciel commented 8 months ago

Ah, I didn't notice that, you are right. Please open a PR with this change – and mention it briefly in your report :)

Ostrzyciel commented 8 months ago

@jakfol1217 I think that's your code – could you have a look at this?

jakfol1217 commented 8 months ago

I opened a PR #38 for this -- sorry, it was a leftover from testing.

Ostrzyciel commented 8 months ago

Merged – please close the issue if this is resolved.

jakfol1217 commented 8 months ago

Closing issue