OpenCTI-Platform / connectors

OpenCTI Connectors
https://www.opencti.io
Apache License 2.0
340 stars 369 forks source link

[crowdsec] Update internal enrichment connector #2252

Closed julienloizelet closed 6 hours ago

julienloizelet commented 4 days ago

Proposed changes

Changed

Added

Removed

Related issues

There is no related issue. This is an update of the existing connector to improve enrichment.

Checklist

Further comments

helene-nguyen commented 3 days ago

@julienloizelet can you please fix linting and formatting? Thanks :)

julienloizelet commented 3 days ago

@julienloizelet can you please fix linting and formatting? Thanks :)

@helene-nguyen : It should be fine now. Thanks

helene-nguyen commented 3 days ago

@julienloizelet The test in the CI failed, I don't lnow really why as everything is aligned! We just released the new minor version, could you try to align the branch with master branch and re-push it again?

julienloizelet commented 3 days ago

@julienloizelet The test in the CI failed, I don't lnow really why as everything is aligned! We just released the new minor version, could you try to align the branch with master branch and re-push it again?

@helene-nguyen : I've just rebased and re-pushed the branch. But CI still fails (the error does not appear to be related to the crowdsec connector, but, who knows). Please let me know if I can do something. Thanks

helene-nguyen commented 2 days ago

@julienloizelet I think I know why, Python will consider the tests folder of google-dns connector as the module to use for your connector. Could you try to change the name of your folder by crowdsec_tests ?

julienloizelet commented 2 days ago

@julienloizelet I think I know why, Python will consider the tests folder of google-dns connector as the module to use for your connector. Could you try to change the name of your folder by crowdsec_tests ?

@helene-nguyen :Thanks for finding this. I ended up moving the tests folder to the src/crowdsec folder (as other connectors do), and all the tests seem to pass now.