[Zerofox] Title indicator and country structure to be corrected

OpenCTI-Platform / connectors

OpenCTI Connectors

https://www.opencti.io

Apache License 2.0

384 stars 415 forks source link

[Zerofox] Title indicator and country structure to be corrected #2828

Open NiQuintin opened 1 month ago

NiQuintin commented 1 month ago

Description

In the latest version of the connector, two small corrections need to be made:

Remove "Pattern for malware" from the title, leaving only the hash in the title.
For the country entities, apply a correction so that they display correctly (see screenshots).

Screenshots (optional)

NiQuintin commented 1 month ago

@DNRRomero last little fix to make. If you have questions do not hesitate.

cc: @helene-nguyen

alexmfarrell commented 1 month ago

Hey there! I understood the original ask from was to not have the hash being the sole title of the entry, as asked here (https://github.com/OpenCTI-Platform/connectors/issues/2780)? You want this reverted back, and just show the hash? 2nd point, you just want the country code, eg "TW" and not "TW-400"? Given these are just cosmetic issues and not functional errors we will have to prioritise this update into our backlog to join other items to be planned. These update should not be affecting the flow of data to the end customer.

NiQuintin commented 1 month ago

Hey @alexmfarrell thanks for your feedback 😊

Yes usually we just add the hash in title like this:

For the countries, the best would be to add the full name of the country or at least just the country code like "TW".

Oh and just seen also for the Indicators, you need to fill in the field x_opencti_main_observable_type otherwise it's gonna be impossible for users to filter on them:

Screenshot 2024-10-21 100701

alexmfarrell commented 4 weeks ago

@NiQuintin Cool, this has been prioritised into our backlog. Will let you know when the PR is ready. Thank you!

alexmfarrell commented 1 week ago

@NiQuintin Hey there! The PR is available now, we've amended the data to display as requested. Let me know if you have any questions. Cheers!!!

yassine-ouaamou commented 1 week ago

Hey @alexmfarrell, Thanks for the heads-up. We haven't seen any Pull request in the repo. Can you submit it in this repository: https://github.com/OpenCTI-Platform/connectors/pulls?

alexmfarrell commented 4 days ago

So sorry, it was sent to the wrong fork. This is the PR here: https://github.com/OpenCTI-Platform/connectors/pull/2988

DNRRomero commented 21 hours ago

Hi @yassine-ouaamou we have the PR ready for review 😄