OpenCTI-Platform / opencti

Open Cyber Threat Intelligence Platform
https://opencti.io
Other
5.15k stars 813 forks source link

[frontend] Fix [Bulk search] Sorting on the columns doesn't work (#7215) #7513

Closed SarahBocognano closed 22 hours ago

SarahBocognano commented 5 days ago

Proposed changes

Related issues

Checklist

Further comments

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.56%. Comparing base (d401814) to head (f9adb79).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #7513 +/- ## ======================================= Coverage 67.55% 67.56% ======================================= Files 567 567 Lines 69903 69903 Branches 5937 5937 ======================================= + Hits 47226 47231 +5 + Misses 22677 22672 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Archidoit commented 2 days ago

Nothing to do with sorting, but can you fix this in your PR : when no author, a '-' should be displayed instead of nothing (like for creation date) image

Archidoit commented 2 days ago

Nothing is displayed in the 'creation date' column whereas entities have a creation date image

Archidoit commented 2 days ago

When you pass the mouse on the 'label' column title, the mouse should be a pointer and not a 'clickable' hand icon. (see exemple when the mouse hovers the label column title in the reports list)

SarahBocognano commented 2 days ago

Update: Comments fixed

Archidoit commented 1 day ago

Everything is ok 👍 just waiting for the tests to pass