OpenCTI-Platform / opencti

Open Cyber Threat Intelligence Platform
https://opencti.io
Other
6.38k stars 945 forks source link

English grammar errors in the toggle labels for the "Update a group" panel #8445

Closed seanthegeek closed 1 month ago

seanthegeek commented 1 month ago

Description

Three of the toggle options at the bottom of the "Update a group" panel have English grammar errors that make what the option does unclear.

Environment

  1. OS (where OpenCTI server runs): Debain 12
  2. OpenCTI version: 6.3.1
  3. OpenCTI client: Frontend

Reproducible Steps

  1. Navigate to Settings> Security
  2. Click Groups
  3. Click on an existing group
  4. Click on the edit/pencil button
Label text Corrected grammar Notes
Automatically authorize this group to new marking definition I'm not sure what this is, considering managing marking definitions are granted be a role capability
Do not accumulate creators for the users of this group I found the request that added the option, but I don't know what accumulating creators means, and I can't find a reference in the documentation
Deny users to delete content not created by them Do not allow users to delete content created by other users

Screenshots (optional)

image

nino-filigran commented 1 month ago

Hi @seanthegeek thanks for your feedback. We'll treat your bug as soon as we can. However I can already give you some hints for your comments in the ticket:

seanthegeek commented 1 month ago

I see, so maybe better labels would be

Label text Corrected text
Automatically authorize this group to new marking definition Allow these users to create new marking definitions
Do not accumulate creators for the users of this group Do not add these users as creators when they edit content
Deny users to delete content not created by them Do not allow these users to delete content created by other users
nino-filigran commented 1 month ago

As a result, we will only change the last one ( Deny users to delete content not created by them TO Do not allow these users to delete content created by other users)