OpenCageData / address-formatting

templates to format geographic addresses
MIT License
394 stars 84 forks source link

German address abbreviation not correct #115

Closed K-Ko closed 1 month ago

K-Ko commented 1 month ago

/conf/abbreviations/de.yaml

road:
     Platz: Pl

I stumbled across the fact that the following address is shortened incorrectly, correct is

Willy-Brandt-Platz 6
81829 München

but formatted result is

Willy-Brandt-Pl 6
81829 München

https://www.openstreetmap.org/search?query=Willy-Brandt-Platz%206%2C%2081829%20M%C3%BCnchen

freyfogle commented 1 month ago

hmm, ja. Thanks for making us aware.

Ok, will add a test case and get a fix out in a few days but it will be to the perl parser. Will be up to each language parser to obey the test.

freyfogle commented 1 month ago

Haven't forgotten about this, just busy with travel and other things. More soon.

K-Ko commented 1 month ago

May be there is another blurring in FR and BE

e.g. Rue des Voituriers becomes r des Voituriers, but OSM:

image

mtmail commented 1 month ago

@K-Ko Can you open a seprate github issue? In which city,country did you find the street?

K-Ko commented 1 month ago

Done, #117, #118

freyfogle commented 1 month ago

the original German issue is now solved in the latest version of the perl parser (Geo::Address::Formatter) and there is now a test in testcases/abbreviations/de.yaml