OpenCerts / legacy-templates

Apache License 2.0
0 stars 25 forks source link

SPtemplate in new renderer #10

Closed ryansena closed 5 years ago

ryansena commented 5 years ago

name: Certificate Template Addition about: This is the workflow for requesting new certificate templates to be added to the OpenCerts repository title: "[New Template]" labels: new template assignees: ''


Pull Request Guidelines for Adding Certificate Templates

This document is a work in progress but here are some basic checks. As these are only basic guidelines, meeting the below doesn't indicate there will be no issues with your pull request.

Pre-merge checks

Certificate Template

rjchow commented 5 years ago

this PR is not ready for review please remove all unused files and unused code that has been commented out

ryansena commented 5 years ago

this PR is not ready for review please remove all unused files and unused code that has been commented out

Hi, the unused files were deleted, except for 1 binary zip file which i could not delete, pls delete it for me or just ignore it.

The comments in the remaining 8 .js files were also removed.

Please review.

rjchow commented 5 years ago

please resolve the build failure as well

rjchow commented 5 years ago

your template is in completely the wrong folder its not possible that this works

Nebulis commented 5 years ago

Closing due to inactivity