Effective Date Changes

[ssgwsg-acn]

---

name: Certificate Template Addition about: This is the workflow for requesting new certificate templates to be added to the OpenCerts repository title: "[New Template]" labels: new template assignees: ''

---

Pull Request Guidelines for Adding Certificate Templates

This document is a work in progress but here are some basic checks. As these are only basic guidelines, meeting the below doesn't indicate there will be no issues with your pull request.

Pre-merge checks

• [ ] Did not modify any files outside of your organisation's template folder (e.g package-lock.json or anything else)
• [ ] Ensure that your code has been rebased on top of latest OpenCerts master
• [ ] Linter issues resolved (Run npm run lint:fix to see issues)
• [ ] npm run test passes
• [ ] npm run test:integration passes
• [ ] Travis Build passes

Certificate Template

• [ ] No more than 5 templates or 25 added/modified files in the pull request
• [ ] Ensure that your .opencert file's data complies with the intentions of the OpenCerts' schema - e.g recipient related information is inside the recipient object, etc.
• [ ] Integration test for each template that checks that the correct rendering is done given a sample certificate
• [ ] Sample certificate file included for each template, located alongside the integration test for each template
• [ ] Sample certificates must obviously be a sample certificate
  • [ ] Obviously fictitious name
  • [ ] Obviously sample signatory images
• [ ] No fixed-size raster images as part of certificate layout
• [ ] Mobile responsive design
• [ ] Date parsing should be localised to template author's timezone
• [ ] Webpack chunking code is correct
  • [ ] Has chunking code
  • [ ] Same chunking code as the other certificates belonging to that institute
• [ ] Certificate Store Addresses have been updated
  • [ ] Template Whitelist
  • [ ] Registry
• [ ] Template should not be using resources(images etc.) on the website outside of their own folder (e.g institute logo shouldn't be used from /static because there's no guarantee it will not change)

[lgtm-com[bot]]

This pull request introduces 3 alerts and fixes 22 when merging dd729c2b9160d918709be1c089b03e6d966cfed9 into 7ec576459db59963527afe83de75eec309d49f58 - view on LGTM.com

new alerts:

• 3 for Unused variable, import, function or class

fixed alerts:

• 21 for Use of returnless function
• 1 for Superfluous trailing arguments

[lgtm-com[bot]]

This pull request introduces 3 alerts and fixes 22 when merging 6f06f56330a32e38981d70fcd3db0c0078bbd9ef into 7ec576459db59963527afe83de75eec309d49f58 - view on LGTM.com

new alerts:

• 3 for Unused variable, import, function or class

fixed alerts:

• 21 for Use of returnless function
• 1 for Superfluous trailing arguments

[thirusparks]

Hi Team, Kindly merge this pull request soon since it is delaying our production deployment plans. --SSGWSG Team