Open ccewuz opened 2 years ago
This pull request introduces 2 alerts when merging 4aeb1db36334ca234f15868202053646f503bd09 into cb5936f3c7d712e099ca145e8c85a798422804cf - view on LGTM.com
new alerts:
please help with merge. thanks
Hi, I'm sorry but this repository is not meant to accept new templates since the 1st Jan
Please reach out to ssg
This pull consists updates to existing templates as well. If cancel this and resubmit a subset of changes w/o new templates, will it be accepted?
Yes we can approve changes to exisiting templates
name: Certificate Template Addition about: This is the workflow for requesting new certificate templates to be added to the OpenCerts repository title: "[New Template]" labels: new template assignees: ''
Pull Request Guidelines for Adding Certificate Templates
This document is a work in progress but here are some basic checks. As these are only basic guidelines, meeting the below doesn't indicate there will be no issues with your pull request.
Pre-merge checks
npm run lint:fix
to see issues)npm run test
passesnpm run test:integration
passesCertificate Template
recipient
object, etc.