OpenCerts / legacy-templates

Apache License 2.0
0 stars 25 forks source link

to add certificate template for RP short course #29

Closed RP-OIS-SK closed 5 years ago

RP-OIS-SK commented 5 years ago

name: Certificate Template Addition about: This is the workflow for requesting new certificate templates to be added to the OpenCerts repository title: "[New Template]" labels: new template assignees: ''


Pull Request Guidelines for Adding Certificate Templates

This document is a work in progress but here are some basic checks. As these are only basic guidelines, meeting the below doesn't indicate there will be no issues with your pull request.

Pre-merge checks

Certificate Template

Nebulis commented 5 years ago

Hi

Integration tests are failing => https://travis-ci.org/OpenCerts/legacy-templates/jobs/587885276

RP-OIS-SK commented 5 years ago

Hi,

No sure why pull request failed the integration test for the new template rp\2019-C-SCA. I have compare the integration.spec and RP_SCA.opencert file with other templates that passed the integration test, there is nothing with it. When I tested it on my notebook, the integration test passed.

Please advise

Thank you and regards,

SK

Nebulis commented 5 years ago

I added a comment to show you the error