Closed mmysgp closed 4 years ago
Hi,
The error comes from TP's code. How could it be merged into the main branch without fix? Since we cannot touch other agency's code, would you please fix it for us and merge our changes? Thanks.
Indeed.... Looks like Travis didn't run send I didn't notice... Will fix
Fixed :ok_hand:
Can advise what is required from us? Can you merge our change?
You should need to rebase or merge into your branch (rebase is simpler imho)
All checks passed. Please help to merge to the master. Thanks.
name: Certificate Template Addition about: This is the workflow for requesting new certificate templates to be added to the OpenCerts repository title: "[New Template]" labels: new template assignees: ''
Pull Request Guidelines for Adding Certificate Templates
This document is a work in progress but here are some basic checks. As these are only basic guidelines, meeting the below doesn't indicate there will be no issues with your pull request.
Pre-merge checks
npm run lint:fix
to see issues)npm run test
passesnpm run test:integration
passesCertificate Template
recipient
object, etc.