OpenCerts / legacy-templates

Apache License 2.0
0 stars 25 forks source link

update NUH logo and include full diploma description in json file #77

Closed mmysgp closed 4 years ago

mmysgp commented 4 years ago

name: Certificate Template Addition about: This is the workflow for requesting new certificate templates to be added to the OpenCerts repository title: "[New Template]" labels: new template assignees: ''


Pull Request Guidelines for Adding Certificate Templates

This document is a work in progress but here are some basic checks. As these are only basic guidelines, meeting the below doesn't indicate there will be no issues with your pull request.

Pre-merge checks

Certificate Template

Nebulis commented 4 years ago

ci is failing https://travis-ci.org/github/OpenCerts/legacy-templates/jobs/669715761?utm_medium=notification&utm_source=github_status

mmysgp commented 4 years ago

Hi,

The error comes from TP's code. How could it be merged into the main branch without fix? Since we cannot touch other agency's code, would you please fix it for us and merge our changes? Thanks.

image

Nebulis commented 4 years ago

Indeed.... Looks like Travis didn't run send I didn't notice... Will fix

Nebulis commented 4 years ago

Fixed :ok_hand:

mmysgp commented 4 years ago

Can advise what is required from us? Can you merge our change?

Nebulis commented 4 years ago

You should need to rebase or merge into your branch (rebase is simpler imho)

mmysgp commented 4 years ago

All checks passed. Please help to merge to the master. Thanks.