name: To add CET BIA
about: This is the workflow for requesting new certificate templates to be added to
the OpenCerts repository
title: "To add CET BIA"
labels: add CET BIA
assignees: ''
Pull Request Guidelines for Adding Certificate Templates
This document is a work in progress but here are some basic checks. As these are only basic guidelines, meeting the below doesn't indicate there will be no issues with your pull request.
Pre-merge checks
[Y] Did not modify any files outside of your organisation's template folder (e.g package-lock.json or anything else)
[Y] Ensure that your code has been rebased on top of latest OpenCerts master
[Y] Linter issues resolved (Run npm run lint:fix to see issues)
[Y] No more than 5 templates or 25 added/modified files in the pull request
[Y] Ensure that your .opencert file's data complies with the intentions of the OpenCerts' schema - e.g recipient related information is inside the recipient object, etc.
[Y] Integration test for each template that checks that the correct rendering is done given a sample certificate
[Y] Sample certificate file included for each template, located alongside the integration test for each template
[Y] Sample certificates must obviously be a sample certificate
[Y] Obviously fictitious name
[Y] Obviously sample signatory images
[Y] No fixed-size raster images as part of certificate layout
[Y] Mobile responsive design
[Y] Date parsing should be localised to template author's timezone
[Y] Webpack chunking code is correct
[Y] Has chunking code
[Y] Same chunking code as the other certificates belonging to that institute
[Y] Certificate Store Addresses have been updated
[Y] Template Whitelist
[Y] Registry
[Y] Template should not be using resources(images etc.) on the website outside of their own folder (e.g institute logo shouldn't be used from /static because there's no guarantee it will not change)
name: To add CET BIA about: This is the workflow for requesting new certificate templates to be added to the OpenCerts repository title: "To add CET BIA" labels: add CET BIA assignees: ''
Pull Request Guidelines for Adding Certificate Templates
This document is a work in progress but here are some basic checks. As these are only basic guidelines, meeting the below doesn't indicate there will be no issues with your pull request.
Pre-merge checks
npm run lint:fixto see issues)npm run testpassesnpm run test:integrationpassesCertificate Template
recipientobject, etc.