search

OpenChain-Project / Online-Self-Certification-Web-App

This is the source code for the OpenChain Project Conformance Online Self-Certification Web App
https://certification.openchainproject.org/
Apache License 2.0
12 stars 5 forks source link

Answer labels not consistently translated #122

Closed goneall closed 5 years ago

goneall commented 5 years ago

The labels for the radio buttons in the questionnaire are not translated when the language is Russian.

This seems to be somewhat intermittent - I've seen it translated some times and not translated others.

In looking at the HTML, it looks like there may be an extra double quote in the input element:

<td class="answer_cell pad_cell"><div class="form-check custom-checkbox"><label class="form-check-label"><input type="radio" class="form-check-input custom-radiobtn" name="answer-1.a" id="answer-1.a_yes" "="" value="yes"><span class="translate" data-i18n="Yes">Yes</span></label></div><div class="form-check custom-checkbox"><label class="form-check-label"><input type="radio" class="form-check-input custom-radiobtn" name="answer-1.a" id="answer-1.a_no" "="" value="no"><span class="translate" data-i18n="No">No</span></label></div></td>

To reproduce the problem, log in to the application, go to the questionnaire tab, change the language to Russian, Change the version to 1.2. The answers should show up in Russian, but they are in english:

image

goneall commented 5 years ago

I did some research and the extra quote problem seems to be in the code prior to the responsive UI work.

goneall commented 5 years ago

Resolved by PR #125