search

OpenChain-Project / Online-Self-Certification-Web-App

This is the source code for the OpenChain Project Conformance Online Self-Certification Web App
https://certification.openchainproject.org/
Apache License 2.0
12 stars 5 forks source link

Add ISO specification information to conformance web app version #192

Closed goneall closed 3 years ago

goneall commented 3 years ago

Currently, only the version number is displayed in the conformance application.

The ISO standard number should be displayed if the questionnaire version is approved by ISO.

goneall commented 3 years ago

Proposed text: Specification Version 2.1 (ISO/IEC 5230:2020)

@shanecoughlan - Please confirm

goneall commented 3 years ago

To implement this, I am planning to hard-code a check in the JavaScript for a specification version 2.1 or higher then display the ISO information only in that case.

An alternative is to make this configurable and add it as a field in the questionnaire JSON file. This would require quite a bit more work (add a column to the database, change the API, additional JavaScript and Java code), but would make sense if the ISO specification string is updated frequently.

My assumption is the ISO number will rarely change, so opting for the hard-coded approach.

@shanecoughlan - let me know if my assumption on the stability of the ISO number is correct.

goneall commented 3 years ago

Resolved with PR #205