search

OpenChain-Project / Online-Self-Certification-Web-App

This is the source code for the OpenChain Project Conformance Online Self-Certification Web App
https://certification.openchainproject.org/
Apache License 2.0
12 stars 5 forks source link

Password reset does not redirect to the password successful page #217

Open goneall opened 3 years ago

goneall commented 3 years ago

When a password reset is completed, the form is cleared and there is no indication the reset was successful. The password reset does occur, the UI just doesn't indicate successful completion.

goneall commented 3 years ago

The code that should redirect to the success page is here:

https://github.com/OpenChain-Project/Online-Self-Certification-Web-App/blob/c1bb58bf0f6d49be822fa8be17f61a082d026e5b/WebContent/resources/pwreset.js#L32

In debugging the issue, the line is executed but the pwresetsuccess.html page is not displayed (or it is quickly redirected back to the original page).

This same redirection code is used in the signup and it successfully works.

goneall commented 3 years ago

It also looks like the translations for the Password Reset Success page is incorrect.

https://github.com/OpenChain-Project/Online-Self-Certification-Web-App/blob/c1bb58bf0f6d49be822fa8be17f61a082d026e5b/WebContent/resources/locales/en/translation.json#L216 should be Password Reset Successful and https://github.com/OpenChain-Project/Online-Self-Certification-Web-App/blob/c1bb58bf0f6d49be822fa8be17f61a082d026e5b/WebContent/resources/locales/en/translation.json#L217 should be You're password has been reset. Please login using the menu above to continue the self certification.

goneall commented 3 years ago

The localizations for Japanese and Korean should also be updated.