search

OpenChain-Project / Telco-WG

This is the OpenChain Telco Work Group
Other
12 stars 6 forks source link

Fix SPDX definition #10

Closed vargenau closed 1 year ago

vargenau commented 1 year ago

Signed-off-by: Marc-Etienne Vargenau marc-etienne.vargenau@nokia.com

stephenkilbaneadi commented 1 year ago

A couple of thoughts here:

  1. I get that "SBOM" is defined immediately before this, but "SBOMs" or "an SBOM" would read a little better.
  2. I'm not sure it's a good idea to turn text into a link without also including the URL in the prose - if the document is printed, the URL is not visible.
vargenau commented 1 year ago

Hi Stephen,

Thank you for your remarks.

I have created a new pull request to update the SBOM definition. I have also made some of the URLs visible. Let us discuss it tomorrow.

Best regards,

Marc-Etienne

From: Stephen Kilbane @.> Sent: Wednesday, November 30, 2022 2:19 PM To: OpenChain-Project/Telco-WG @.> Cc: Marc-Etienne Vargenau (Nokia) @.>; Author @.> Subject: Re: [OpenChain-Project/Telco-WG] Fix SPDX definition (PR #10)

A couple of thoughts here:

  1. I get that "SBOM" is defined immediately before this, but "SBOMs" or "an SBOM" would read a little better.
  2. I'm not sure it's a good idea to turn text into a link without also including the URL in the prose - if the document is printed, the URL is not visible.

— Reply to this email directly, view it on GitHubhttps://github.com/OpenChain-Project/Telco-WG/pull/10#issuecomment-1332143701, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAC4KKR2PUHTNZLCGKHU3Q3WK5H5HANCNFSM6AAAAAASONY2NU. You are receiving this because you authored the thread.Message ID: @.**@.>>