Damage popups, warning shutups

OpenChamp / client

The Godot Project for OpenChamp

GNU General Public License v3.0

127 stars 18 forks source link

Damage popups, warning shutups #88

Closed konradybcio closed 2 months ago

cmkrist commented 3 months ago

DamagePopup and TimeElapsed need lowercase, code looks good but haven't pulled yet

noah1510 commented 2 months ago

Do you mind recreating the pr for the 4.3_update branch? Keep in mind that the new code has multiple damage types, so different colors for them will be required.

konradybcio commented 2 months ago

yes, eventually.. unless someone has time and is willing to look into this earlier, then go for it

noah1510 commented 2 months ago

Then I will create an implementation based on this later myself. I'll tag you in the commit to make it clear the original idea was by you.

noah1510 commented 2 months ago

It's implemented and working in f951406