Closed javigon closed 6 years ago
It’s a good idea. Then let’s remove this patch from the fixes.
Javier
On 6 Jun 2018, at 14.03, Matias Bjørling notifications@github.com wrote:
@MatiasBjorling commented on this pull request.
In hw/block/nvme.c:
@@ -2915,6 +2915,8 @@ static void lnvm_exit(NvmeCtrl *n) if (ln->meta_auto_gen) free(ln->meta_fname); fclose(ln->metadata); +
- printf("Remove lnvm\n"); What if there are multiple nvme instances, then it will be hard to know which one exited. How about polling using "info" command? Would that be better?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
Updated PR with comments applied
pblk panics if file is created using a+ (when the meta file doesn't exists previously).
Would it be better to create the state of the file, and then use it?
done
Set of small fixes for lnvm and nvme