search

OpenChemistry / avogadrolibs

Avogadro libraries provide 3D rendering, visualization, analysis and data processing useful in computational chemistry, molecular modeling, bioinformatics, materials science, and related areas.
https://two.avogadro.cc/
BSD 3-Clause "New" or "Revised" License
450 stars 174 forks source link

Regression: first item in ordered plugin dialog is empty #1632

Open matterhorn103 opened 8 months ago

matterhorn103 commented 8 months ago

Avogadro version: (please complete the following information from the About box):

Desktop version: (please complete the following information):

Describe the bug The bug that I described and fixed here seems to be back.

Weirdly, it doesn't occur on my personal build of Avogadro from the latest codebase. However, it does in the 1.99 AppImage, I get the impression it's also happening on Windows, and @JGrantHill also reports it happening on macOS (ARM).

To Reproduce Steps to reproduce the behavior:

  1. Install the avo_xtb plugin
  2. Open the "Configure..." menu or anything else that has a dialog e.g. Run or Conformers
  3. Observe that first field is always empty, even after entering a path and saving the config, or after adding the path manually to Avogadro/commands/avo_xtb/config.json
avo-bot commented 8 months ago

This issue has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/regression-first-item-in-ordered-plugin-dialog-is-empty/5320/1

avo-bot commented 4 weeks ago

This issue has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/xtb-plugin-installation/6340/15

matterhorn103 commented 2 weeks ago

Still bizarrely remains the case that the version of Avogadro that I have compiled myself doesn't have this issue, but all other versions apparently do.

Could this be a bug that was fixed in very recent Qt5 versions? I compiled against 5.15.15, whereas the nightly AppImage is compiled against 5.15.2.

ghutchis commented 2 weeks ago

That's certainly possible. Is the qt6 version able to run the plugins? If so, does that fix the bug?

My feeling is that it's probably better to push ahead with migrating to qt6 sooner.

matterhorn103 commented 2 weeks ago

Is the qt6 version able to run the plugins?

No, sadly. That's actually the only thing I've been able to spot that doesn't work in my Qt6 build.

matterhorn103 commented 2 weeks ago

QRegularExpression has 38 instances in avogadrolibs, many of them in files related to the plugins, so I'll prioritize porting those over the next week or so, and maybe that will solve everything...

ghutchis commented 2 weeks ago

@matterhorn103 - why don't you post something on the forum. Maybe a few others would be willing to help with porting.

IIRC some of that has to do with context highlighting in the input generators, which isn't so crucial. That could be #ifdef for qt5-only for now.