OpenChemistry / avogadrolibs

Avogadro libraries provide 3D rendering, visualization, analysis and data processing useful in computational chemistry, molecular modeling, bioinformatics, materials science, and related areas.
https://two.avogadro.cc/
BSD 3-Clause "New" or "Revised" License
435 stars 166 forks source link

Generated CP2K input is invalid #1701

Open e-kwsm opened 2 weeks ago

e-kwsm commented 2 weeks ago

Avogadro version: (please complete the following information from the About box):

Desktop version: (please complete the following information):

Describe the bug Generated CP2K input is malformed. See ja.txt (Japanese locale).

Regarding Energy calculation:

I have not checked the other calculation types.

To Reproduce

2
carbon monoxide
C          0.00000        0.00000        0.00000
O          1.05700        0.00000        0.00000
  1. Open the above XYZ file
  2. Navigate to "Input" → "CP2K"
  3. "Save File…" without modification

Expected behavior Generated CP2K input is valid.

Screenshots

Screenshot from 2024-09-01 06-32-33

ghutchis commented 2 weeks ago

Some of these would be fairly easy for me to fix, but since I don't use cp2k, I'll definitely need help from other users.

The code is at https://github.com/OpenChemistry/avogadrolibs/blob/master/avogadro/qtplugins/cp2kinput/cp2kinputdialog.cpp

e-kwsm commented 2 weeks ago

1702