search

OpenChemistry / avogadrolibs

Avogadro libraries provide 3D rendering, visualization, analysis and data processing useful in computational chemistry, molecular modeling, bioinformatics, materials science, and related areas.
https://two.avogadro.cc/
BSD 3-Clause "New" or "Revised" License
461 stars 172 forks source link

Export to MP4 should test for "avconv" in path #282

Open badarsh2 opened 6 years ago

badarsh2 commented 6 years ago

https://github.com/OpenChemistry/avogadrolibs/blob/da6ebb9f0e39c73ca861001e390d13e6ed3e6cb5/avogadro/qtplugins/playertool/playertool.cpp#L249

This requires avconv to be installed in the system. If avconv is not installed, this particular snippet still executes, but no mp4 file is saved and there is no warning or error thrown saying that avconv is not found.

https://github.com/OpenChemistry/avogadrolibs/blob/da6ebb9f0e39c73ca861001e390d13e6ed3e6cb5/avogadro/qtplugins/playertool/playertool.cpp#L232 In Windows, the png export itself isn't taking place. avconv execution will also presumably fail I guess. Should we resort to including libraries for these in the build?

ghutchis commented 6 years ago

I'll leave that to @cryos, but I'd rather set this as optional - the playertool code should detect if avconv is available and disable the feature if not found.

SonaliK7654 commented 1 year ago

Hey! @ghutchis could you please elaborate this issue? As I'm new to open source contribution.