search

OpenChemistry / openchemistry

Supermodule containing submodules and external project to build all components
http://openchemistry.org/
BSD 3-Clause "New" or "Revised" License
81 stars 53 forks source link

Upgrade spglib to fix msvc build #48

Closed psavery closed 6 years ago

psavery commented 6 years ago

It appears that spglib was performing pointer arithmetic on a void pointer in 1.10.3. This is allowed in GCC, but not in MSVC. Spglib appears to have fixed this in 1.10.4.

psavery commented 6 years ago

I did not actually test this on windows to see if it works. My windows laptop is at home. It works on linux at least.

psavery commented 6 years ago

I saw some of our AppVeyor runs pass after this PR got merged, so I think it fixed it!