search

OpenChemistry / stempy

Toolkit for 4D STEM processing on HPC using a Python interface and C++ engine. https://stempy.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
22 stars 11 forks source link

Looking denoising data before counting #233

Open cjh1 opened 2 years ago

ercius commented 2 years ago

We will need to apply a filter (or general function) to the image before counting. This also could allow for adaptive dark fields and gains to be applied.

cjh1 commented 2 years ago

I think we spoke about this a little in the past. The issue we have with allow for a generic function/filter is the cost between jumping from C++ to Python. We can definitely try this approach and see how it performs, but my guess is it might come with a bit of overhead. Are there specific filters that you had in mine?

ercius commented 2 years ago

I forgot about that. Lets stick with C++ for speed. I have an example filter which we can try out.

There are also ideas about an adaptive dark field, but I need to develop the algorithm and see if its worth implementing. But we would need to allow the function to read and modify the data for pre-counting filters.

ercius commented 2 years ago

Ah yes. Now I remember. That will complicate things. Ill work on the filter that I have seen published which would be easy to translate into C++ if it works. If you have other ideas for denoising that would work too. So, maybe a way to call a C++ function would be the best way forward.

On Tue, Mar 8, 2022 at 9:12 AM Chris Harris @.***> wrote:

I think we spoke about this a little in the past. The issue we have with allow for a generic function/filter is the cost between jumping from C++ to Python. We can definitely try this approach and see how it performs, but my guess is it might come with a bit of overhead. Are there specific filters that you had in mine?

— Reply to this email directly, view it on GitHub https://github.com/OpenChemistry/stempy/issues/233#issuecomment-1062009406, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXORFHOPYZELN46UJSS3MTU66C7NANCNFSM5QENOMRQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>