search

OpenChemistry / stempy

Toolkit for 4D STEM processing on HPC using a Python interface and C++ engine. https://stempy.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
22 stars 11 forks source link

Build wheels for Python 3.11 also #295

Closed psavery closed 1 year ago

psavery commented 1 year ago

I believe Python 3.11 wheels were being skipped because, at the time, several dependencies did not have Python 3.11 support.

But our dependencies should have Python 3.11 support now. So let's add back in Python 3.11.

Fixes: #294

psavery commented 1 year ago

@cjh1 I updated the dockerhub wheelbuilder to use manylinux2014 instead of manylinux2010. This is because manylinux2010 is no longer supported as of about a year ago. manylinux2010 also does not contain python3.11, but manylinux 2014 does.

psavery commented 1 year ago

After adding Python 3.11, upgrading our docker image to manylinux2014, and upgrading pybind11 to the latest version, building the Python 3.11 wheels now appears to work!

@ercius feel free to download a Python 3.11 wheel from here to give it a try. I hope upgrading pybind11 didn't introduce any issues.

Once this PR is approved, we can merge it, and then push a tag, and then Python 3.11 wheels should be available on PyPI.

swelborn commented 1 year ago

looks good.

@ercius should still check if all functionality is still there after upgrading pybind11.