OpenChemistry / tomviz

Cross platform, open source application for the processing, visualization, and analysis of 3D tomography data
https://tomviz.org/
BSD 3-Clause "New" or "Revised" License
325 stars 87 forks source link

Binning tilt images does not change pixel size #2293

Open ercius opened 1 year ago

ercius commented 1 year ago

Describe the bug When you use the binning function called "Bin tilt images x2" and "Bin Volume x2" the data dimensions are changed incorrectly. The full size of the data is divided by two when instead the pixel size should be reduced by two.

Example data loaded as-is: bin0

object size: image

Example data binned by 2: bin2

Object size: image

Note that the scale cube is the same size in both screenshots while the object reduces in size by 2x. The physical extent of the object should not change when it is binned. Instead, fewer pixels extend across the same physical dimension leading to the pixel/voxel size being increased by 2.

To Reproduce Steps to reproduce the behavior:

  1. Load example tilt or reconstruction data
  2. Select Data Transforms -- Bin Volume x2 OR Select Tomography -- Bin Tilt Images x2
  3. Check the size of the object
  4. The extent of the object is half the size when it should be unchanged.

Expected behavior The physical extent of the object should be unchanged.

Desktop (please complete the following information):

dikshasaraswa commented 11 months ago

Hi @ercius Can I take the issue ?