search

OpenChemistry / tomviz

Cross platform, open source application for the processing, visualization, and analysis of 3D tomography data
https://tomviz.org/
BSD 3-Clause "New" or "Revised" License
325 stars 86 forks source link

Crash when closing progress message dialog during transform #850

Closed yijiang1 closed 7 years ago

yijiang1 commented 7 years ago

tomviz crashes if I close (by clicking the cross button screen shot 2017-01-31 at 3 39 30 pm) the progress message dialog during a transform.

mathturtle commented 7 years ago

We were testing similar things... if you have a transform running and click the X button on the tomviz main window, you end up with a zombie background thread that is stuck in its event loop. I have #852 to help steer users away from this, but it doesn't actually fix it.

yijiang1 commented 7 years ago

The latest binary (0.9.3-16-g6b94623) on Mac still crashes when doing tomographic reconstructions. Also, I don't see the message box.

mathturtle commented 7 years ago

The fix for this issue didn't make it into the release. Did you click the X button on the progress dialog when testing this or did the reconstructions crash without you doing anything? I'm having trouble making it crash, although I am seeing some errors when trying to run the FFT-based reconstructions.

mathturtle commented 7 years ago

Misclicked the 'comment and close button'... oops.

yijiang1 commented 7 years ago

Did you click the X button on the progress dialog when testing this

Yes. The reconstruction works fine itself.

I often use Weighed Back Projection for testing (with default parameters).

mathturtle commented 7 years ago

It doesn't seem like Qt provides a good way to hide the X button. At least not without direct platoform-level calls. There are some flags, but the implementation is free to ignore if the platform doesn't support it. I have a branch (#886) that should fix the crash though. But if the operator doesn't support canceling, it will keep running in the background until it finishes.

cjh1 commented 7 years ago

@yijiang1 I think this can be closed?

yijiang1 commented 7 years ago

Yup it doesn't crash any more.