search

OpenChirp / website

Angular 7 based web-frontend for OpenChirp.
3 stars 6 forks source link

Required Service Config Fields Not Enforced #118

Open linux4life798 opened 6 years ago

linux4life798 commented 6 years ago

The service config (single) item is totally free-form and has no schema validation at the REST side, so it is up to the website to make use of the required config parameters and manage schema.

The website is not enforcing the required field flag and does not "unset" fields that are optional+blank.

linux4life798 commented 6 years ago

It actually generates a config that could be considered malformed.

This is what is generated when you fill in none of the config boxes. Notice there are no "value" items.

"config":[{"key":"Required1"},{"key":"Optional1"},{"key":"Required2"},{"key":"Optional2"}]