OpenChrom / openchrom

Visualization and Analysis of mass spectrometric and chromatographic data.
https://www.openchrom.net
Eclipse Public License 1.0
82 stars 24 forks source link

Import CDF with RetentionUnit="s" specified #489

Closed avasyanin closed 3 months ago

avasyanin commented 3 months ago

CDF files exported by Chromatec Analytic 2.6 program have RetentionUnit specified as "s", not "seconds", so their time scale after reading by OpenChrom is incorrect. The issue probably can be easily solved by adding "s" to the line 87 of https://github.com/OpenChrom/openchrom/tree/develop/openchrom/plugins/net.openchrom.csd.converter.supplier.cdf/src/net/openchrom/csd/converter/supplier/cdf/io/support/AbstractCDFChromatogramArrayReader.java file:

if(unit.equals("seconds") || unit.equals("Seconds")) {

Thanks.

eselmeister commented 3 months ago

Great, thanks for the hint. Could you share a CDF file for testing purposes?

avasyanin commented 3 months ago

Yes, sure.

The file also contains some supporting information which is in an ancient CP1251 (Cyrillics), but actually it is not very important.

20240327-174018 [169.3] (1).cdf.zip

eselmeister commented 3 months ago

@avasyanin Thanks for the file. It has been fixed and will be shipped with the next release, scheduled for Friday, 5th of April.

Screenshot from 2024-03-30 11-00-07