Use BuildBuiltinCallExpr to generate call to __builtin_addressof

OpenCilk / opencilk-project

Monorepo for the OpenCilk compiler. Forked from llvm/llvm-project and based on Tapir/LLVM.

Other

93 stars 29 forks source link

Use BuildBuiltinCallExpr to generate call to __builtin_addressof #182

Closed neboat closed 1 year ago

neboat commented 1 year ago

This change looks good to me, and it seems to fix the related issues I was running into compiling some complicated Cilk/C++ codes.

If you have a chance, can you please add a regression test for this change?

VoxSciurorum commented 1 year ago

I am unable to reproduce the error in a reasonably sized test. Something in <complex> is required to provoke an error message in the original test, despite complex numbers being apparently irrelevant. A preprocessed file including <complex> is over 2 megabytes.