search

OpenClinica / enketo-oc

OpenClinica's fork of the Enketo web forms monorepo
Apache License 2.0
0 stars 5 forks source link

File uploads multipart fieldName investigation #122

Open enketo-issue-mover opened 6 years ago

enketo-issue-mover commented 6 years ago

From @MartijnR on June 23, 2016 19:16

This was changed here to fix a bug: https://github.com/kobotoolbox/enketo-express/commit/db209a7a0e8ea9db8c532d05e0308da33c9bcba7#diff-fc82a39d32fe16f88fc6848922ae0aa3

It's causing some issues in OC. Previously there was no issue with repeated file input fields. So the linked commit may be be fixing an older regression (that was never deployed on OC).

Copied from original issue: kobotoolbox/enketo-express#525

enketo-issue-mover commented 6 years ago

From @MartijnR on June 28, 2016 19:40

It seems there wasn't an Enketo bug. If so the original bug OpenClinica/enketo-express-oc#431 is a mystery.

enketo-issue-mover commented 6 years ago

From @MartijnR on June 28, 2016 19:58

The issue is with KoBoCAT and Ona, which was the reason to change it.

enketo-issue-mover commented 6 years ago

From @MartijnR on June 28, 2016 20:10

So 3 solutions:

  1. change OC
  2. revert change in enketo-express-oc port only
  3. fix Ona and KoBoToolbox to properly deal with multipart/formdata fields that have the same name.
enketo-issue-mover commented 6 years ago

From @MartijnR on June 30, 2016 17:39

http://codepen.io/MartijnR/pen/rLypxO?editors=0010