OpenClinica / enketo-oc

OpenClinica's fork of the Enketo web forms monorepo
Apache License 2.0
0 stars 1 forks source link

refactored repeathandler customization in the Pages module, #728 #3

Closed MartijnR closed 5 months ago

MartijnR commented 6 months ago

@kkrumlian, @gushil, @pbowen-oc, as discussed, here is an example (an exceptionally nice one tbh) to demonstrate the kind of refactoring I propose to do in the monorepo.

The previous approach was taken to be able to keep using the official enketo-core npm module without forking it. This is no longer required with the monorepo.

Advantages:

Disadvantage:

When refactoring is done the whole page.js file in enketo-express would be removed as all its customizations would have moved to enketo-core.

MartijnR commented 6 months ago

PS. don't approve and merge this as it still requires more work. It is just useful to show the approach for now.

MartijnR commented 5 months ago

There is a failing test (enketo-core web) that I cannot reproduce locally. For now, it's okay to ignore and ready for review.

I'll add the other PRs on top of this one, so please review the PRs in order.